-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven Support #262
Maven Support #262
Conversation
Any idea when/if this will get included? |
No idea, I've not heard anything from Facebook. |
I dont think anybody from facebook looks at these pull requests. I created a feature request with my branch linked to it |
Conflicts: .gitignore examples/Hackbook/default.properties
From other fb projects on github, they ask that you create bugs on their bug system, if you want them to pay any attention. Also I bet they have an internal private repository that they publish out to this public one. they probably don't like to take in any submissions.. :( :( So it might be really low chance, but you probably want to create a bug in their system pointing back to these pull requests. And I'll keep my fingers crossed too. |
I made a public fork with a pom setup that worked for me (the pull requests in here had a few minor issues). |
I have created a bug in their internal system and also talked to James Pearce about it at AnDevCon as well as the state of pull requests here.. we will see what comes out of this |
I made a pull request to add maven support to the preview branch at #282 . There are still some issues though, see the pull request for more details. |
Updated for 3.0.0: #289 |
Thanks for submitting a pull request to the Facebook SDK. We’re sorry we haven’t responded sooner but we are cleaning up old pull requests so that we can better respond to new requests. We're hoping to add Maven support soon. |
I've added Maven support to the Facebook Android SDK if you'd like it.
Alex