Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Support #262

Closed
wants to merge 5 commits into from
Closed

Maven Support #262

wants to merge 5 commits into from

Conversation

alex-richards
Copy link

I've added Maven support to the Facebook Android SDK if you'd like it.

Alex

@billmag
Copy link

billmag commented May 2, 2012

Any idea when/if this will get included?

@alex-richards
Copy link
Author

No idea, I've not heard anything from Facebook.

@mosabua
Copy link

mosabua commented May 11, 2012

I dont think anybody from facebook looks at these pull requests. I created a feature request with my branch linked to it
https://github.com/mosabua/facebook-android-sdk/tree/maven and they will look at it in the future. If I get around to it I will push this to central myself in the next weeks.

Alex Richards added 2 commits May 28, 2012 16:51
@fern
Copy link

fern commented May 29, 2012

From other fb projects on github, they ask that you create bugs on their bug system, if you want them to pay any attention. Also I bet they have an internal private repository that they publish out to this public one. they probably don't like to take in any submissions.. :( :(

So it might be really low chance, but you probably want to create a bug in their system pointing back to these pull requests. And I'll keep my fingers crossed too.

@billmag
Copy link

billmag commented May 29, 2012

I made a public fork with a pom setup that worked for me (the pull requests in here had a few minor issues).
https://github.com/Appboy/facebook-android-sdk

@mosabua
Copy link

mosabua commented May 29, 2012

I have created a bug in their internal system and also talked to James Pearce about it at AnDevCon as well as the state of pull requests here.. we will see what comes out of this

@billmag
Copy link

billmag commented Nov 14, 2012

I made a pull request to add maven support to the preview branch at #282 . There are still some issues though, see the pull request for more details.

@billmag
Copy link

billmag commented Jan 3, 2013

Updated for 3.0.0: #289

@gcaglar
Copy link
Contributor

gcaglar commented Oct 3, 2014

Thanks for submitting a pull request to the Facebook SDK. We’re sorry we haven’t responded sooner but we are cleaning up old pull requests so that we can better respond to new requests. We're hoping to add Maven support soon.

@gcaglar gcaglar closed this Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants